Skip to content
Success

Changes

Summary

  1. Fix uninitialized value in tls_create_object (commit: b804b8e) (details)
  2. Point stubby at my repo. (commit: 5721c50) (details)
  3. Sync tools shared with unbound (commit: f3a38e9) (details)
  4. Stub only links with GNUTLS (commit: 3b5d1a9) (details)
  5. Dependencies for travis (+ testing...) (commit: f73bf0d) (details)
  6. Testing GNUTLS DoT tests (commit: f05c0ad) (details)
  7. Fix: mem leak with gnutls (commit: e17ed39) (details)
  8. Fix reporting authentication failure (commit: af46e20) (details)
  9. Update stubby. (commit: 3073d33) (details)
  10. Eliminate compile error (commit: 9c8b70e) (details)
  11. Name only authentication with GNUTLS (commit: e7d435e) (details)
  12. Run all tests again (commit: 6894159) (details)
  13. Revise recent lookup3.c update to restore building on Windows. (commit: 822d8ad) (details)
  14. CMake libunbound fixups. (commit: f01e718) (details)
  15. Work around dnsmasq issue (commit: ef45547) (details)
  16. Point ssl_dane submodule back at getdnsapi version. (commit: e96e334) (details)
  17. Update stubby. (commit: 252d68e) (details)
  18. Print GnuTLS debug messages (commit: c234865) (details)
  19. Relax GnuTLS priority strings slightly to allow getdns to work with TLS1.3 servers. (commit: 9baf655) (details)
  20. Fix DoT with GnuTLS >= 3.6 (commit: 26a95b5) (details)
  21. Update Stubby to pick up latest Stubby release tag and Windows packaging details. (commit: be09306) (details)
  22. Issue #466: Memory leak with retrying queries (commit: 3c6756d) (details)
Commit b804b8effb11e519a844520b252d1078512e0c05 by zakraise
Fix uninitialized value in tls_create_object

On the first call to tls_create_object (stub.c), tls_fallback_ok is read
before being initialized. This patch initializes tls_fallback_ok to 0 in
upsteam_init (context.c)

Valgrind complains about the uninitialized value:
==14774== Conditional jump or move depends on uninitialised value(s)
==14774==    at 0x1528C3: tls_create_object (stub.c:900)
==14774==    by 0x1556AD: upstream_connect (stub.c:2065)
==14774==    by 0x15582E: upstream_find_for_transport (stub.c:2109)
==14774==    by 0x1558B7: upstream_find_for_netreq (stub.c:2130)
==14774==    by 0x156027: _getdns_submit_stub_request (stub.c:2296)
==14774==    by 0x1421C8: _getdns_submit_netreq (general.c:478)
==14774==    by 0x14261D: getdns_general_ns (general.c:636)
==14774==    by 0x142905: _getdns_general_loop (general.c:731)
==14774==    by 0x1432FB: getdns_general (general.c:888)
==14774==    by 0x118B94: incoming_request_handler (stubby.c:692)
==14774==    by 0x14F46B: udp_read_cb (server.c:762)
==14774==    by 0x15C86B: poll_read_cb (poll_eventloop.c:295)
==14774==  Uninitialised value was created by a heap allocation
==14774==    at 0x483877F: malloc (vg_replace_malloc.c:309)
==14774==    by 0x123CCF: upstreams_create (context.c:581)
==14774==    by 0x128B24: getdns_context_set_upstream_recursive_servers (context.c:2760)
==14774==    by 0x12DBFE: _getdns_context_config_setting (context.c:4646)
==14774==    by 0x12FF47: getdns_context_config (context.c:4769)
==14774==    by 0x1178C2: parse_config (stubby.c:297)
==14774==    by 0x117B24: parse_config_file (stubby.c:343)
==14774==    by 0x11919F: main (stubby.c:833)
(commit: b804b8e)
The file was modified src/context.c (diff)
Commit 5721c501c3073ff5410b6c99abcf9ae39a1ca0d0 by jim
Point stubby at my repo.
(commit: 5721c50)
The file was modified .gitmodules (diff)
Commit f3a38e9a402956a92bc8486663e15e29c316ee73 by willem
Sync tools shared with unbound
(commit: f3a38e9)
The file was modified src/gldns/parse.c (diff)
The file was modified src/util/lookup3.c (diff)
The file was modified src/gldns/wire2str.c (diff)
The file was modified src/tls/val_secalgo.c (diff)
The file was modified src/gldns/str2wire.c (diff)
The file was modified src/util/import.sh (diff)
Commit 3b5d1a93536d125c9deadba8cf668188b22c0977 by willem
Stub only links with GNUTLS

And valgrind check includes DoT session
(commit: 3b5d1a9)
The file was modified src/gnutls/tls.c (diff)
The file was modified src/test/tpkg/225-stub-only-valgrind-checks.tpkg/225-stub-only-valgrind-checks.supp (diff)
The file was modified src/test/tpkg/200-stub-only-compile-install.tpkg/200-stub-only-compile-install.pre (diff)
The file was modified src/test/tpkg/225-stub-only-valgrind-checks.tpkg/225-stub-only-valgrind-checks.queries (diff)
Commit f73bf0dfa5b7ae6d045ed3efb859f558956389ce by willem
Dependencies for travis (+ testing...)
(commit: f73bf0d)
The file was modified .travis.yml (diff)
The file was modified .travis.yml (diff)
The file was modified src/gnutls/tls.c (diff)
Commit af46e20721f1b803ef16864be42198b9ca181a73 by willem
Fix reporting authentication failure
(commit: af46e20)
The file was modified src/stub.c (diff)
The file was modified src/gnutls/tls.c (diff)
The file was modified stubby (diff)
The file was modified src/gldns/wire2str.c (diff)
Commit e7d435e4266cf589fd7dc98b73302bf76db3d3c5 by willem
Name only authentication with GNUTLS
(commit: e7d435e)
The file was modified src/stub.c (diff)
The file was modified .travis.yml (diff)
Commit 822d8ad7038b09802fa379eeccf8f53ea7667fe1 by jim
Revise recent lookup3.c update to restore building on Windows.

As we're now building with CMake, and CMake can supply endianness, just insist on using that.
(commit: 822d8ad)
The file was modified src/util/lookup3.c (diff)
Commit f01e7188c8c5253449ff6774b195b9d1152eeeb7 by jim
CMake libunbound fixups.

1. ub_ctx_set_stub is in unbound.h, not unbound-events.h.
2. Only bother looking for unbound event API if enabled.
3. If building stub only, ensure all libunbound items are off. This is necessary in case we first configure without stub only, and then change to stub only.

Fixes #463
(commit: f01e718)
The file was modified CMakeLists.txt (diff)
The file was modified src/test/check_getdns_common.c (diff)
Commit e96e33493244d54dd7cc816791fdc8a544ad9031 by jim
Point ssl_dane submodule back at getdnsapi version.
(commit: e96e334)
The file was modified .gitmodules (diff)
The file was modified src/ssl_dane (diff)
The file was modified stubby (diff)
Commit c234865a80d0a3f620c5c3d8016e33aabfc96a33 by willem
Print GnuTLS debug messages
(commit: c234865)
The file was modified src/gnutls/tls.c (diff)
Commit 9baf655a7bc666773152fee553105807ad9fcbc0 by jim
Relax GnuTLS priority strings slightly to allow getdns to work with TLS1.3 servers.

Now GnuTLS 3.6.5 and later are in the field, we've run into problems handshaking with TLS1.3 servers with a GnuTLS build. OpenSSL works fine. Comparing the client handshake of GnuTLS and OpenSSL, we found GnuTLS was being considerably more restrictive. This change loosens the restriction so GnuTLS presents nearly the same set of cipher and other options and OpenSSL. OpenSSL provides more signature algorithms. The change gets GetDNS working against Quad1, Quad8, Quad9 and the getdnsapi servers.
(commit: 9baf655)
The file was modified src/gnutls/tls.c (diff)
Commit 26a95b5b8a213096641654c5b97976e66ec32e5d by willem
Fix DoT with GnuTLS >= 3.6
(commit: 26a95b5)
The file was modified src/gnutls/tls.c (diff)
Commit be09306567a22f55a3a6b73873b2c0cb114aec0e by jim
Update Stubby to pick up latest Stubby release tag and Windows packaging details.
(commit: be09306)
The file was modified stubby (diff)
Commit 3c6756d68b3792b3b5a812913c13d031a18a5343 by willem
Issue #466: Memory leak with retrying queries

(for examples with search paths).
Thanks doublez13.
(commit: 3c6756d)
The file was modified src/request-internal.c (diff)
The file was modified ChangeLog (diff)
The file was modified src/tools/getdns_query.c (diff)